Add example for newtype parameter in routes
#57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add parens to previous examples that failed compilation.
|
|
natefaubion
requested changes
May 28, 2018
GUIDE.md
Outdated
| Using the following routes with a `newtype`: | ||
| ```purescript | ||
| newtype PostId = PostID Int | ||
| derive instance newtypePostID :: Newtype PostId _ |
There was a problem hiding this comment.
Some inconsistent casing (PostId vs PostID).
GUIDE.md
Outdated
| | PostBrowse String String | ||
| ``` | ||
|
|
||
| It is possible to warp an `int` route parameter into a `PostId` using the |
GUIDE.md
Outdated
| following function: | ||
| ```purescript | ||
| postId :: forall f. MatchClass f => f PostId | ||
| postId = pure wrap <*> int |
There was a problem hiding this comment.
This is wrap <$> int, but I would prefer PostId <$> int.
GUIDE.md
Outdated
| postId = pure wrap <*> int | ||
| ``` | ||
|
|
||
| The created `postId` function can then be used like the `str` function. |
There was a problem hiding this comment.
str isn't a function. I would say "parser" instead.
|
I've addressed Nate's feedback above, but we still need a changelog entry file, which can't be added in this PR AFAIK unless the original author adds that change. |
JordanMartinez
approved these changes
Sep 23, 2021
thomashoneyman
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add parens to previous examples that failed compilation.