Skip to content

Rename matchHash and matchHash' #32

Closed
@menelaos

Description

@menelaos

The guide mentions that this library only supports hash-based routing. The actual matching, however, is completely agnostic to where it gets the URL string from:

matchHash :: forall a. Match a -> String -> Either String a
matchHash' :: forall a. (String -> String) -> Match a -> String -> Either String a

I would thus propose to drop the Hash part and rename the above two functions into match and either match' or matchWith. If you approve of this, I will open a PR later today.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions