Use null for mempty ReactElement#187
Merged
natefaubion merged 2 commits intopurescript-contrib:mainfrom Jan 4, 2023
Merged
Conversation
JordanMartinez
approved these changes
Jan 4, 2023
Contributor
JordanMartinez
left a comment
JordanMartinez
left a comment
There was a problem hiding this comment.
Should this be publicized, so that people are aware of this change?
Contributor
Author
|
I think it would be fine to just release it as a major version bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This updates the Monoid/Semigroup instances of
ReactElementto representmemptyasnullrather than an empty fragment, which is more in line with API expectations for third-party libraries. Due to that, this can technically be considered a breaking change? However, this change is not observable within the exported purescript-react types and interface.Checklist: