Events

[ethul]

Initial work for updating the representation of events. This is still a work in progress, but putting up what I have so far.

Resolves #85
Resolves #135
Resolves #136

@natefaubion @unclechu @arthurxavierx - Any feedback is most welcome.

[natefaubion]

Sorry I missed this. I don't see how this is type safe though. If SyntheticEvent is a raw Record and not an opaque newtype, then it cannot be safe to call the event methods (like preventDefault)? Additionally, some properties like defaultPrevented are mutable (Boolean).

[ethul]

Good points. Maybe the alternative to go the type class direction (#136 (comment)) would be safer. I would definitely be open to writing this that way. What do you think?

[natefaubion]

I think row types are a fine fit, but treating it as a record is not safe for two reasons:

• A SyntheticEvent is not immutable before calling persist due to event pooling
• Something that is not actually a Record should not be typed as Record. This is often convenient but breaks down when you use any Record operations for updates, merges, etc.

I think you could possibly provide an opaque newtype indexed by fields and provide a general SProxy based getter that works over Eff, with partial applications.

[ethul]

Thanks. Along these lines sounds good. I was testing out the following. Is this kind of like what you are suggesting?

foreign import data SyntheticEvent_ :: # Type -> Type

type SyntheticEventRow r
  = ( bubbles :: Boolean
    , cancelable :: Boolean
    , currentTarget :: NativeEventTarget
    , defaultPrevented :: Boolean
    , eventPhase :: Number
    , isTrusted :: Boolean
    , nativeEvent :: NativeEvent
    , target :: NativeEventTarget
    , timeStamp :: Number
    , type :: String
    | r
    )

type SyntheticUIEventRow r
  = ( detail :: Number
    , view :: NativeAbstractView
    | r
    )

get
  :: forall eff l r s a
   . RowCons l a r s
  => IsSymbol l
  => SProxy l
  -> SyntheticEvent_ s
  -> Eff eff a
get l r = unsafeGet (reflectSymbol l) r

foreign import unsafeGet :: forall eff r a. String -> SyntheticEvent_ r -> Eff eff a

type SyntheticEvent'' r = SyntheticEvent_ (SyntheticEventRow r)

type SyntheticUIEvent'' = SyntheticEvent_ (SyntheticUIEventRow (SyntheticEventRow ()))

bubbles :: forall eff r. SyntheticEvent'' r -> Eff eff Boolean
bubbles = get (SProxy :: SProxy "bubbles")

detail :: forall eff. SyntheticUIEvent'' -> Eff eff Number
detail = get (SProxy :: SProxy "detail")

[natefaubion]

Yes, exactly.

[ethul]

Great! I will send a PR for this, probably tomorrow.

…

On Sat, Apr 14, 2018 at 16:14 Nathan Faubion ***@***.***> wrote: Yes, exactly. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#140 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVYy3Z1MmoaMpS23oO5yESx5ua8Si2aks5toli-gaJpZM4TOPz1> .