Update according to Contributors library guidelines #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
41 tasks
| @@ -25,7 +25,7 @@ import Data.String.NonEmpty.CodeUnits (cons, singleton) as NES | |||
| import Partial.Unsafe (unsafePartial) | |||
| import Pathy.Name (Name) | |||
| import Pathy.Path (Path, foldPath, (</>)) | |||
| import Pathy.Phantom (class IsDirOrFile, class IsRelOrAbs, Dir, Rel, foldDirOrFile, foldRelOrAbs, kind DirOrFile, kind RelOrAbs) | |||
| import Pathy.Phantom (class IsDirOrFile, class IsRelOrAbs, Dir, Rel, foldDirOrFile, foldRelOrAbs) | |||
There was a problem hiding this comment.
Just now getting to this.
Could you explain why the two kinds here were removed? Is this because you're also updating this lib for the v0.14.0-rc2 release?
There was a problem hiding this comment.
It's just because they aren't used in this code, and so this produced a compiler warning. Nothing to do with 0.14!
There was a problem hiding this comment.
I think kinds weren't considered in the import usage checking previously, which is why it became a warning now.
There was a problem hiding this comment.
Gotcha. Thanks for clarifying.
JordanMartinez
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of an effort to update and standardize the Contributors libraries according to the Library Guidelines. Specifically, it:
testdirectory.This PR is the groundwork for followup efforts to ensure contributor libraries are kept up-to-date, documented, tested, and accessible to users and new contributors.