-
Notifications
You must be signed in to change notification settings - Fork 17
Update to v0.15.0 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v0.15.0 #44
Conversation
const nullImpl = null; | ||
export { nullImpl as null }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be:
const nullImpl = null; | |
export { nullImpl as null }; | |
export const nullImpl = null; |
or is the workaround necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, null
is exported as is in PureScript:
module Nullable (null) where
foreign import null :: forall a. Nullable a
So, if I changed it to export const nullImpl = null;
, then the PureScript code needs to be changed, too:
module Nullable (null) where
null :: forall a. Nullable a
null = nullImpl
foreign import nullImpl :: forall a. Nullable a
So, the change I've made is the lesser diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course; I see. Thanks!
Description of the change
Backlinking to purescript/purescript#4244
Migrates FFI to ES modules
Checklist: