-
Notifications
You must be signed in to change notification settings - Fork 17
Update according to Contributors library guidelines #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update according to Contributors library guidelines #30
Conversation
Note: this currently fails because of the
|
Unless @hdgarrood or @garyb object, we can switch to use |
I think the use of |
@garyb I've disabled those rules so the code can remain as-is. |
I think that's why it was set to I'd forgotten about all this stuff, the JS knowledge is slowly coming back after a long time spent in pure-purescript-land 😆 |
I'm not particularly familiar with https://github.com/purescript-contrib/governance/blob/main/updater/templates/js/.eslintrc.json and it's pretty easy to drop a quick update to this library and other libraries using the same config. |
I think going with the most restrictive one for the template makes sense. Null comparisons aren't all that common in FFI code I imagine (I don't think they should be at least!), so the fact it highlights things like this makes us rethink and reassess what's happening during these updates, which I think is a good thing. |
Would you prefer that we switch that rule to |
Comment works for me, it reiterates that the choice is intentional. |
This pull request is part of an effort to update and standardize the Contributors libraries according to the Library Guidelines. Specifically, it:
test
directory.This PR is the groundwork for followup efforts to ensure contributor libraries are kept up-to-date, documented, tested, and accessible to users and new contributors.