add toInt and toNumber #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigma-andex
reviewed
Mar 27, 2023
| @@ -19,6 +19,8 @@ export const fromInt = (n) => BigInt(n); | |||
|
|
|||
| export const fromTypeLevelInt = (str) => BigInt(str); | |||
|
|
|||
| export const toNumber = (n) => Number(n); | |||
There was a problem hiding this comment.
Shouldn't this check whether n is in range?
There was a problem hiding this comment.
I'm not quite sure about this point but I think checking is not necessary because Number() returns +infinity or -infinity (which are valid Purescript numbers) if the bounds are not checked.
By the way, no function in Data.Number (like pow or acos) does checking.
Neither does purescript-bigints' toNumber function.
There was a problem hiding this comment.
I think it's okay to return +infinity or -infinity but that should be documented. The toNumber export should say “If the BigInt is too positive then the result will be +Infinity. If the BigInt is too negative, then the result will be -Infinity.” or something like that.
sigma-andex
approved these changes
Mar 27, 2023
sigma-andex
approved these changes
Apr 4, 2023
jamesdbrock
reviewed
Apr 4, 2023
jamesdbrock
reviewed
Apr 4, 2023
jamesdbrock
reviewed
Apr 4, 2023
jamesdbrock
reviewed
Apr 4, 2023
jamesdbrock
approved these changes
Apr 4, 2023
Co-authored-by: James Brock <jamesbrock@gmail.com>
Co-authored-by: James Brock <jamesbrock@gmail.com>
Co-authored-by: James Brock <jamesbrock@gmail.com>
Co-authored-by: James Brock <jamesbrock@gmail.com>
f-f
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add toInt and toNumber
add new tests