Add cursor CSS property #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, don't merge yet, going to refactor this to replace |
vyorkin
force-pushed
the
feature/add-cursor
branch
2 times, most recently
from
a88ef45 to
b7d762c
Compare
|
Refactored, ready for review |
vyorkin
commented
Jul 9, 2018
| | SWResize | ||
| | EWResize | ||
| | NSResize | ||
| | NESWResize |
There was a problem hiding this comment.
not the best names, but that's how its named in CSS :)
vyorkin
force-pushed
the
feature/add-cursor
branch
from
b7d762c to
908f145
Compare
|
btw, there is a couple of other pending PR's as well (which are already rebased), I can rebase this one if it looks good to @garyb |
|
@thomashoneyman Would you merge this if we do another rebase? |
|
Yes, I will. Thanks everyone! |
thomashoneyman
approved these changes
Jul 9, 2020
|
@vyorkin Happy to merge this once it's conflict-free. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds is a very basic cursor support.
Cursor URLs aren't implemented.
Resolves #92