Skip to content

Add text direction #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add text direction #83

wants to merge 2 commits into from

Conversation

vyorkin
Copy link
Collaborator

@vyorkin vyorkin commented Jul 5, 2018 •
edited
Loading

Add direction CSS property along with the new TextDirection type and ltr / rtl values.

@vyorkin vyorkin force-pushed the feature/add-text-direction branch 2 times, most recently from 632a98e to 02a6422 Compare July 6, 2018 19:55
@vyorkin
Copy link
Collaborator Author

vyorkin commented Jul 8, 2018 •
edited
Loading

Please, don't merge yet, going to refactor this to replace newtype with sum type like we did in #95.
Also, I think it makes sense not to re-export ltr and rtl from the CSS module as we've recently discussed in #93 - does this still sound ok or it's better to export those values (because they're unique)?

@vyorkin vyorkin force-pushed the feature/add-text-direction branch 2 times, most recently from 3dae1e4 to f381ecb Compare July 8, 2018 19:05
@vyorkin vyorkin force-pushed the feature/add-text-direction branch from f381ecb to 55e12a1 Compare July 10, 2018 20:51
@thomashoneyman thomashoneyman changed the base branch from master to main October 6, 2020 03:09
JordanMartinez
JordanMartinez approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the need to add an entry to the Changelog file, this change looks good to me. However, we might need to complete it via a separate PR.

@JordanMartinez JordanMartinez mentioned this pull request Sep 23, 2021
Merged
4 tasks
@JordanMartinez
Copy link
Contributor

Superceded by #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanMartinez JordanMartinez JordanMartinez approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyorkin @JordanMartinez @thomashoneyman