flex-grow and flex-shrink typed as Number
#64
Conversation
|
|
andywhite37
force-pushed
the
flex-number
branch
from
b0bb3ea to
b9041dd
Compare
|
Hello, I just discovered I had this long-forgotten open pull request. It's just a tiny change, and not likely to make much of a difference, but I just got it up-to-date with master, so it should be mergable. |
andywhite37
force-pushed
the
flex-number
branch
from
b9041dd to
f4bc8f1
Compare
|
I see that flex can take number values, not just integers, as in your link (https://drafts.csswg.org/css-flexbox-1/#flex-property) and Mozilla (https://developer.mozilla.org/en-US/docs/Web/CSS/flex). I think this is reasonable. |
|
@andywhite37 Could you add a summary of this change in the "Breaking Changes" section of this repo's CHANGELOG.md file? We should merge after that. |
The `flex` shorthand, `flex-grow`, and `flex-shrink` properties appear to allow Numbers as values, not just Ints. I ran into this tonight while trying to implement a flex-based slider control. See below: https://drafts.csswg.org/css-flexbox-1/#flex-property
andywhite37
force-pushed
the
flex-number
branch
from
f4bc8f1 to
9b65c3f
Compare
|
@JordanMartinez - done, let me know if that looks okay. Thanks to you and @thomashoneyman for noticing this PR - it was no big deal, but happy to see it get merged! |
|
Thanks! |
The
flexshorthand,flex-grow, andflex-shrinkproperties appear to allow Numbers as values, not just Ints. I ran into this tonight while trying to implement a flex-based slider control.See below:
https://drafts.csswg.org/css-flexbox-1/#flex-property