Add text-transform rule. #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
requested changes
Dec 29, 2016
| show (Capitalize) = "capitalize" | ||
| show (None) = "none" | ||
| show (Initial) = "initial" | ||
| show (Inherit) = "inherit" |
There was a problem hiding this comment.
This Show instance breaks the (informal) law that it should print the code that generates the value. Doing this for value would be correct, but here we'd want to print the capitalized values.
|
Sorry, I forgot there were a bunch of outstanding PRs on here. Could you sign the CLA? Then I'll get the rest of them merged/make a release. Thanks! |
|
CLA signed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.