Skip to content

updated for purescript v0.9.1 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2016
Merged

Conversation

deamme
Copy link
Contributor

@deamme deamme commented Jun 18, 2016

No description provided.

@deamme
Copy link
Contributor Author

deamme commented Jun 18, 2016

All tests work using "pulp test".
I can't get the gulp build to work though, so please help me with that.

@deamme deamme closed this Jun 18, 2016
@deamme deamme reopened this Jun 18, 2016
@deamme
Copy link
Contributor Author

deamme commented Jun 19, 2016

Should be fixed now.

@deamme
Copy link
Contributor Author

deamme commented Jun 19, 2016

Something went wrong, I think Travis should rebuild it again.

@garyb
Copy link
Member

garyb commented Jun 21, 2016

Travis doesn't get along with purescript unless we use the trusty build now for some reason. If we use these lines in the .travis.yml it should work: https://github.com/purescript/purescript-prelude/blob/4650e8dbb4d3f6c7b870b61d908ef6f64503ee34/.travis.yml#L2-L3

Although generally we can drop all the gulp stuff and just use a pulp build anyway. I can do that afterwards though.

@@ -1,4 +1,6 @@
language: node_js
dist: trusty
sudo: required
sudo: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to take this one out too 😉

with (Selector (Refinement fs) e) (Refinement ps) = Selector (Refinement (fs <> ps)) e
infix 0 child as ##
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be better to work out some sensible fixities for these operators based on the way they combine rather than trying to emulate the previous situation of unspecified fixities.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used it enough to understand what the best fixities are..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise 😄

Ok, I'll open a new issue for that and address it before releasing the new version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, haha 😄

@garyb
Copy link
Member

garyb commented Jun 21, 2016

Thanks for working on this!

@garyb garyb merged commit 3fe427e into purescript-contrib:master Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants