-
Notifications
You must be signed in to change notification settings - Fork 38
updated for purescript v0.9.1 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All tests work using "pulp test". |
Should be fixed now. |
Something went wrong, I think Travis should rebuild it again. |
Travis doesn't get along with purescript unless we use the Although generally we can drop all the gulp stuff and just use a pulp build anyway. I can do that afterwards though. |
@@ -1,4 +1,6 @@ | |||
language: node_js | |||
dist: trusty | |||
sudo: required | |||
sudo: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to take this one out too 😉
with (Selector (Refinement fs) e) (Refinement ps) = Selector (Refinement (fs <> ps)) e | ||
infix 0 child as ## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be better to work out some sensible fixities for these operators based on the way they combine rather than trying to emulate the previous situation of unspecified fixities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used it enough to understand what the best fixities are..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise 😄
Ok, I'll open a new issue for that and address it before releasing the new version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, haha 😄
Thanks for working on this! |
No description provided.