Skip to content

Add top-level CSS module #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2015

Conversation

cdepillabout
Copy link
Member

This pull-request adds a top-level CSS module that exports all the the CSS.* sub-modules, except for CSS.Render. It also removes an uneeded import from the testing file.

One small problem is that maxWidth is exported from both CSS.Geometry and CSS.Media. I hid the maxWidth from CSS.Media. I made this decision pretty much arbitrarily, so if you think something else should be done, let me know.

Also, please let me know if there are modules other than CSS.Render that shouldn't be exported.

It doesn't appear that the test file is actually using anything from the
Data.These module.
@puffnfresh
Copy link
Contributor

Thank you! I've wanted this, PureScript just didn't have re-exports at the time.

👍

@garyb
Copy link
Member

garyb commented Dec 8, 2015

Thanks! 👍

Maybe we should omit the entire re-export of CSS.Media rather than hiding the conflicting name, as it might be confusing as to why the maxWidth in scope doesn't work for a Feature value, but other Media-related things do? I don't mind too much either way though.

@cdepillabout
Copy link
Member Author

@garyb: Sounds good. I removed the export of CSS.Media.

@garyb
Copy link
Member

garyb commented Dec 8, 2015

Thanks!

garyb added a commit that referenced this pull request Dec 8, 2015
@garyb garyb merged commit a7d476e into purescript-contrib:master Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants