Skip to content

Added table selector #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Conversation

plurip-software
Copy link
Contributor

Missing Table Selector

While using purescript-halogen-css I became aware of the non-existance of a separate table selector.


Checklist:

  • [ x] Added specific table selector as 'table_' (table wasn't available as a function name since it is already used for the ' display table' in CSS.Display).

@nsaunders
Copy link
Member

Hi @plurip-software, thanks for your submission.

Regarding the name conflict, I really appreciate that you maintained backward compatibility by preserving the existing function name. However, since we have other breaking API changes in the pipeline anyway (as of today), it seems like now might be a good time to resolve that conflict by renaming the existing table function to displayTable (as has been done in Clay). What do you think?

@plurip-software
Copy link
Contributor Author

Sounds good !

@nsaunders
Copy link
Member

Excellent, thanks @plurip-software. Would you be interested in adding another commit to make that change? If not, I can do it for you. Just let me know!

@plurip-software
Copy link
Contributor Author

I will do it ! I'm pretty new to collaborating on GitHub, so I hope I don't mess something up^^

@nsaunders nsaunders merged commit 0ee14df into purescript-contrib:main Feb 2, 2022
@nsaunders
Copy link
Member

Looks great -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants