Fixed NEL import; Fixed Number/Int issues; Builds Now #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very good 👍 |
|
Great, thanks! |
garyb
added a commit
that referenced
this pull request
Dec 2, 2015
Fixed NEL import; Fixed Number/Int issues; Builds Now
|
Thanks @born2defy! And welcome to the wonderful world of open source. 😃 Awesome first pull request. 👍 |
|
Thank you! I hope to try and contribute more as I am very grateful for the work you guys (and others) have done with this incredible language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I was experimenting with this library and had to revise a few minor things to get the Site module to build with the latest version of the purescript compiler. Specifically I had to change the original import of Data.Array.NonEmpty to Data.NonEmpty, I had to break out the foreign imports into their own js module, and I had to add a bunch of .0's to change many of the ints to numbers. I'm not sure if this is useful to you or not, but since it is done I thought I would share it in case that it is.
Thank you for the excellent library. I am not a professional developer so please excuse me if I am not handling this correctly as this is literally the first pull request I have ever initiated.