-
Notifications
You must be signed in to change notification settings - Fork 9
Update according to Contributors library guidelines #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,4 +1,3 @@ | |||
/* globals exports, setTimeout */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are already understood as global by the configuration.
cell.prev = queue.last; | ||
queue.last.next = cell; | ||
queue.last = cell; | ||
case 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The eslint configuration requires indents here; there is no semantic change anywhere in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this fact.
}, | ||
"devDependencies": { | ||
"eslint": "^4.19.1", | ||
"pulp": "^12.2.0", | ||
"purescript-psa": "^0.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be removing purescript-psa
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point; it's not normally included because we normally don't even have a package.json file, and Spago is assumed as a requirement for all libraries. But in this case you're already going to npm i
and then use a build command that explicitly relies on psa, so we may as well include it.
"radix": [2, "always"], | ||
"indent": [2, 2], | ||
"quotes": [2, "double"], | ||
"semi": [2, "always"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familar wit eslintrc.json
's configuration file, but I'm assuming 2
is a short-hand way of referring to error
, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right.
This pull request is part of an effort to update and standardize the Contributors libraries according to the Library Guidelines. Specifically, it:
test
directory.This PR is the groundwork for followup efforts to ensure contributor libraries are kept up-to-date, documented, tested, and accessible to users and new contributors.