Skip to content

Migrate the library to use Spago #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Migrate the library to use Spago #81

merged 4 commits into from
Jun 19, 2020

Conversation

thomashoneyman
Copy link
Contributor

What does this pull request do?

This PR migrates this library to use Spago instead of Pulp and Bower. Spago has become the default package manager and build tool for the community and this is a step towards standardizing all the contributor libraries on Spago.

This also updates CI to use Spago instead of Bower.

How should this be manually tested?

I have manually verified that the Bower file only has dependencies already included in the previous Bower file and at the same major versions -- the new generated one includes a few extra entries, but these are transitive dependencies that would already have been present.

@thomashoneyman thomashoneyman self-assigned this Jun 19, 2020
"test": "pulp test"
"clean": "rimraf output",
"build": "spago build",
"test": "spago -x test/test.dhall test"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a separate config for tests so that test dependencies can be kept out of the generated Bower file.

@thomashoneyman thomashoneyman merged commit d8f3a9c into master Jun 19, 2020
@thomashoneyman thomashoneyman deleted the spago branch June 19, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants