-
Notifications
You must be signed in to change notification settings - Fork 78
Implement customized AJAX requests #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Separate executing an XHR into 3 stages: - preparing - callback wiring - sending - Allow the underlying XHR to be manipulated before it is sent
|
Bump; would the idea of this still be useful? (I found this issue while trying to figure out how to get timeouts working, eg. via |
|
This PR would have been helpful to me. Why wasn't it merged? Just because of the CLA, or for some other reason? |
|
I think, at the time, I was concerned about adding features that wouldn't also work correctly on Node. Later, I wanted to do something that provided the Affjax interface and you would choose a "driver" or something for it that explicitly determined whether it was for Node or XHR. I haven't spent the time to figure that out still. Nowadays, there's also edit: The CLA thing was a requirement when this library was under |
|
I say we close this PR. Ideally, |
|
I think what I said above is still right, and it's not something we need to do here. There's maybe something that could be done in the driver repo(s) that would allow extra capabilities (pass something in when "creating" a driver value - maybe it's like I'll close this because of that. |
|
Another option is to increase the driver interface, passing in |
Proposed fix for #50.
Adds two new public functions:
customAffjaxandcustomAffjax'which allow the underlying XHR to be inspected/manipulated before it is sent. This makes it possible to add an event listener for theprogressevent, for example.To enable this, execution of the XHR was divided into three stages: