Restore parse fix for JSON responses #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Closing #54. |
garyb
force-pushed
the
restore-json-parse
branch
from
254b6c1 to
e8497d8
Compare
garyb
added a commit
that referenced
this pull request
Jan 7, 2016
Restore parse fix for JSON responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55 - @cdepillabout thanks, it wasn't changed intentionally, I'm not sure how it got lost
Resolves #54 - @teh the code you noticed went missing was replaced with this that also went missing at some point, I think this is a better fix as it will automatically apply the fix for any JSONResponse rather than having to handle it in every instance that expects it.