[Feature request] update netcoredbg gadget to support exceptions

[sebaFlame]

netcoredbg recently added exceptionBreakpointFilters support: netcoredbg commit

this should be available in 1.2.0-825
Unfortunately it doesn't seem to be a drop-in replacement, it breaks breakpoints and I can not configure exceptions filters.

[puremourning]

If netcoredbg has regressed, then I'm not going to update to a version that's broken. Maybe report the regression to them ?

[sebaFlame]

There is also the issue of the exception filters not being sent. From what I understand so far, the filters should get sent when a breakpoint gets set?

.vimspector.json

{
  "adapters": {
    "netcoredbg-debug": {
      "attach": {
        "pidProperty": "processId",
        "pidSelect": "ask"
      },
      "command": [
        "${gadgetDir}/netcoredbg/netcoredbg",
        "--interpreter=vscode",
        "--engineLogging=${workspaceRoot}/netcoredbg.engine.log",
        "--log=${workspaceRoot}/netcoredbg.log"
      ],
      "configuration": {
        "cwd": "${workspaceRoot}"
      },
      "name": "netcoredbg-debug"
    }
  },
  "configurations": {
    "test - netcoredbg": {
      "adapter": "netcoredbg-debug",
      "breakpoints": {
        "exception": {
            "unhandled": "Y",
            "user-unhandled": "Y",
            "throw": "Y",
            "all": "N"
        }
      },
      "configuration": {
        "request": "attach",
	  }
    }
  }
}

"all" & "user-unhandled" are supported

Log for 1.2.0-782 -
_vimspector_log_Vimspector_782.log
Log for 1.2.0-825 -
_vimspector_log_Vimspector_825.log

[puremourning]

hmm. That does seem odd.

Let me try it out.

[puremourning]

OK actually I can't. There's another reason we can't move to this version - no macOS binary.

[puremourning]

Samsung/netcoredbg#66

[sebaFlame]

Apparently (Samsung/netcoredbg#65 (comment)) it Just Works™. Using the new https://github.com/Samsung/netcoredbg/releases/download/1.2.0-825/netcoredbg-linux-amd64_fixed.tar.gz @viewizard provided. I seem to be hitting a corner case with the way I'm debugging tests. Exception filters still do not get sent tho.

[puremourning]

feel free to use the latest build that works on linux, but I won't be updating vimsepctor while there are known issues and missing platform support. Other clients are also hitting issues : sar/free-omnisharp-vscode-LTS#3

[sebaFlame]

Fixed and verified by me (Samsung/netcoredbg#65 (comment)). I see no macOS build has been provided yet tho...