Skip to content

Fix logger httpclient #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix logger httpclient #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion resources/sdk/purecloudgo/extensions/default_httpclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,22 @@ package platformclientv2

import (
"context"
"log"
"net/http"
"net/url"
"os"
"time"

"github.com/hashicorp/go-retryablehttp"
)

type retryableLogger struct {
logger *log.Logger
}

func (rl *retryableLogger) Printf(format string, v ...interface{}) {
}

// DefaultHttpClient wraps retryablehttp.Client to provide HTTP functionality with automatic retries
type DefaultHttpClient struct {
client retryablehttp.Client
Expand Down Expand Up @@ -57,12 +66,13 @@ func (c *DefaultHttpClient) SetHttpsAgent(agent *ProxyAgent) {
// NewDefaultHttpClient creates and returns a new DefaultHttpClient instance with default settings
func NewDefaultHttpClient(proxyAgent *ProxyAgent) *DefaultHttpClient {
timeout, err := time.ParseDuration("16s")
logger := log.New(os.Stdout, "", log.Ldate|log.Ltime)
if err != nil {
panic(err)
}

client := retryablehttp.NewClient()
client.Logger = nil
client.Logger = &retryableLogger{logger: logger}
client.HTTPClient.Timeout = timeout
if proxyAgent != nil && proxyAgent.ProxyURL != "" {
proxyURL, err := url.Parse(proxyAgent.ProxyURL)
Expand Down