[NLU-3867] Arabic Currency Support #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhickey25
requested review from
kevinwalshgen,
colm-dillon,
andrew-gradinari,
Conor-Keaney,
KanchanKumar12 and
BobbyMartins5
colm-dillon
approved these changes
Oct 19, 2023
| @@ -11,3 +8,5 @@ | |||
| from .portuguese_numeric_with_unit import PortugueseNumericWithUnit | |||
| from .spanish_numeric_with_unit import SpanishNumericWithUnit | |||
| from .japanese_numeric_with_unit import JapaneseNumericWithUnit | |||
| from .catalan_numeric_with_unit import CatalanNumericWithUnit | |||
There was a problem hiding this comment.
🤔 - seems not to have impacted Catalan amountOfMoney
There was a problem hiding this comment.
it's probably not necessary but I put it in for consistency
andrew-gradinari
approved these changes
Oct 19, 2023
| CurrencySuffixList = dict([("Abkhazian apsar", "أبخازية أبسار"), | ||
| ("Afghan afghani", "أفغاني أفغاني|؋|الأفغاني|أفغاني"), | ||
| ("Pul", "بول"), | ||
| ("Euro", "يورو|اليورو|€|يورو"), |
There was a problem hiding this comment.
I see some, like Australian Dollar have AUD, US Dollar have USD specified as well, so should this include EUR?
There was a problem hiding this comment.
ah yeah, no harm
kevinwalshgen
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.