Skip to content

Commit

Permalink
Add flashblade.snapshotDirectoryEnabled to enable/disable snapshots o…
Browse files Browse the repository at this point in the history
…n FlashBlade (purestorage#67)

Also referring to https://docs.openshift.com/container-platform/3.11/install_config/persistent_storage/persistent_storage_flex_volume.html
flexvolume driver directory corrected for Atomic host in all comments.
  • Loading branch information
dinathom authored Mar 14, 2019
1 parent 3d13c27 commit 1eabd47
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
7 changes: 4 additions & 3 deletions pure-k8s-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ The following table lists the configurable parameters and their default values.
| `flasharray.defaultFSOpt` | Block volume default mkfs options. *Not recommended to change!* | `-q` |
| `flasharray.defaultMountOpt` | Block volume default filesystem mount options. *Not recommended to change!* | "" |
| `flasharray.preemptAttachments` | Enable/Disable attachment preemption! | `true` |
| `flashblade.snapshotDirectoryEnabled` | Enable/Disable FlashBlade snapshots | `false` |
| `namespace.pure` | Namespace for the backend storage | `k8s` |
| `orchestrator.name` | Orchestrator type, such as openshift, k8s | `k8s` |
| `flexPath` | Full path of directory to install flex plugin, works with image.tag >= 2.0.1 | `/usr/libexec/kubernetes/kubelet-plugins/volume/exec` |
Expand Down Expand Up @@ -150,8 +151,8 @@ This upgrade will not impact the in-use volumes/filesystems from data path persp
/usr/libexec/kubernetes/kubelet-plugins/volume/exec/pure~flex
# for openshift 3.10+ on RHEL Atomic
root@k8s-test-openshift-0:~# find /etc/origin/node/kubelet-plugins/ -name "flex" | xargs dirname
/etc/origin/node/kubelet-plugins/volume/exec/pure~flex
root@k8s-test-openshift-0:~# find /etc/origin/kubelet-plugins/ -name "flex" | xargs dirname
/etc/origin/kubelet-plugins/volume/exec/pure~flex
```
## Platform and Software Dependencies
Expand Down Expand Up @@ -250,7 +251,7 @@ running the kubelet service.
The kubelet configuration is then set via the `node-config.yaml` in the
`kubeletArguments` section to set the `volume-plugin-dir`. The easiest
path to use is something like `/etc/origin/node/kubelet-plugins` or similar
path to use is something like `/etc/origin/kubelet-plugins` or similar
as the node config path is passed through to the container.
# License
Expand Down
2 changes: 2 additions & 0 deletions pure-k8s-plugin/templates/pure-provisioner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ spec:
value: {{ .Values.namespace.pure }}
- name: PURE_DEFAULT_BLOCK_FS_TYPE
value: {{ .Values.flasharray.defaultFSType }}
- name: PURE_DEFAULT_ENABLE_FB_NFS_SNAPSHOT
value: {{ .Values.flashblade.snapshotDirectoryEnabled }}
volumes:
- name: config
configMap:
Expand Down
5 changes: 4 additions & 1 deletion pure-k8s-plugin/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ flasharray:
defaultMountOpt: ""
preemptAttachments: "true"

flashblade:
snapshotDirectoryEnabled: "false"

# there are two namespaces for this app
# 1. namespace.pure is the backend storage namespace where volumes/shares/etc
# will be created.
Expand All @@ -53,7 +56,7 @@ orchestrator:
flexPath: /usr/libexec/kubernetes/kubelet-plugins/volume/exec

# Default for Openshift 3.10+ on RHEL Atomic (containerized kubelet/origin-node)
#flexPath: /etc/origin/node/kubelet-plugins/volume/exec
#flexPath: /etc/origin/kubelet-plugins/volume/exec

# Default for Openshift 3.9 and lower with RHEL Atomic
#flexPath : /usr/libexec/kubernetes/kubelet-plugins/volume/exec
Expand Down

0 comments on commit 1eabd47

Please sign in to comment.