Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Pure via NPM #454

Merged
merged 8 commits into from
Mar 5, 2015
Merged

Publish Pure via NPM #454

merged 8 commits into from
Mar 5, 2015

Conversation

jamesalley
Copy link
Contributor

For this PR I have run npm init on Pure's package.json and then made a few edits (such as changing the name from "pure" to "purecss") so that we will be able to publish the build files to NPM. I've also added an .npmignore file so that only the build folder will be published.

Once published to NPM, the "purecss" NPM package will differ from the previous purecss NPM package in the following ways:

  1. All the .css files will be in the package's /build folder instead of in root.
  2. The version will have changed, of course.

Anyone who's been using npm to drop Pure into their project will have to adapt to this slight change in directory structure.

… so I can publish the build files to NPM right from the pure repo. Added an .npmigore file to that end.
@yahoocla
Copy link

yahoocla commented Mar 4, 2015

CLA is valid!

"repository": {
"type": "git",
"url": "git://github.com/yahoo/pure.git"
},
"scripts": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepublish script to run the build? So we don't ever publish a stale build.

@okuryu
Copy link

okuryu commented Mar 4, 2015

I like the whitelist by using the files field in package.json instead of using .npmignore file. .npmignore is blacklist, so it's not able to do unkown stuff handling.

@ericf
Copy link
Collaborator

ericf commented Mar 5, 2015

Looking good. @jamesalley it's up to you on @okuryu's suggestion.

After merging this, you can update the version locally to 0.6.0-test-1 and trying publishing. If it looks good, then we can do it for real.

@tivac any thoughts on this? Specifically all the files being in build/ instead of using the pure-release repo like @undoZen did in the past…

@ericf ericf mentioned this pull request Mar 5, 2015
@tivac
Copy link

tivac commented Mar 5, 2015

👍x💯

Very excited for updated purecss NPM package.

As for the somewhat-breaking change...

394 downloads in the last month

I'm responsible for at least 20 of those, so I think you're probably ok!

jamesalley added a commit that referenced this pull request Mar 5, 2015
@jamesalley jamesalley merged commit 8a650c3 into pure-css:master Mar 5, 2015
@jamesalley jamesalley deleted the npmdist branch March 5, 2015 18:04
@jamesalley
Copy link
Contributor Author

I have noticed one side effect: pure-min.css becomes purecss-min.css because of the name change in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants