-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Pure via NPM #454
Publish Pure via NPM #454
Conversation
… so I can publish the build files to NPM right from the pure repo. Added an .npmigore file to that end.
CLA is valid! |
"repository": { | ||
"type": "git", | ||
"url": "git://github.com/yahoo/pure.git" | ||
}, | ||
"scripts": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prepublish script to run the build? So we don't ever publish a stale build.
I like the whitelist by using the |
Looking good. @jamesalley it's up to you on @okuryu's suggestion. After merging this, you can update the @tivac any thoughts on this? Specifically all the files being in |
👍x💯 Very excited for updated As for the somewhat-breaking change...
I'm responsible for at least 20 of those, so I think you're probably ok! |
I have noticed one side effect: pure-min.css becomes purecss-min.css because of the name change in package.json. |
For this PR I have run npm init on Pure's package.json and then made a few edits (such as changing the name from "pure" to "purecss") so that we will be able to publish the build files to NPM. I've also added an .npmignore file so that only the build folder will be published.
Once published to NPM, the "purecss" NPM package will differ from the previous purecss NPM package in the following ways:
Anyone who's been using npm to drop Pure into their project will have to adapt to this slight change in directory structure.