Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added media queries for 2.5K and 4K screens #1065

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Conversation

ahron1
Copy link
Contributor

@ahron1 ahron1 commented Sep 24, 2022

When building a page with a grid of cards, if the layout takes up the full width of the screen, there are significant differences between FHD, QHD, and 4K screens. What looks good on a FHD screen, can look either sparse or stretched out on a QHD/4K screen.

So I extended it to include 2.5K (xxxl) and 4K (x4k) media queries.

I use it from the local directory but it'd be better to have it over the CDN, so others can use it also.

@toobr
Copy link

toobr commented Oct 18, 2022

@redonkulus Is there any plan for merging this? We want to be able to use it on prod.

Copy link
Contributor

@redonkulus redonkulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will release asap

@redonkulus redonkulus merged commit a42d226 into pure-css:master Oct 19, 2022
@redonkulus
Copy link
Contributor

Now released in purecss@2.2.0

@ileadu
Copy link

ileadu commented Apr 2, 2023

-xxxl could be -x2k for short.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants