Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mode line indicator customizable #8

Merged
merged 1 commit into from
Jan 10, 2016

Conversation

peniblec
Copy link
Contributor

@peniblec peniblec commented Jan 9, 2016

Largely inspired by Magit's lighters, eg for magit-blame-mode.

Thank you for this package! I like it so much I basically enabled it as globally as I could (ie for fundamental, text, prog and special modes).

(First pull request ever, let me know if I am doing something wrong)

@purcell
Copy link
Owner

purcell commented Jan 10, 2016

Thanks! I'll merge this, but I'd generally suggest that people use diminish to customize or remove minor mode modeline indicators.

purcell added a commit that referenced this pull request Jan 10, 2016
Make mode line indicator customizable
@purcell purcell merged commit 2b8b800 into purcell:master Jan 10, 2016
@xiongtx
Copy link
Contributor

xiongtx commented May 18, 2017

How'd we end up with PgLn and not ^L? 😛

@purcell
Copy link
Owner

purcell commented May 18, 2017

How'd we end up with PgLn and not ^L? 😛

Both are a bit ugly, I think. Personally I prefer to completely diminish this minor mode. :-)

@peniblec
Copy link
Contributor Author

Personally I prefer to completely diminish this minor mode. :-)

I have to admit that diminish does the job perfectly, as I found out literally minutes after you merged this PR. I had no idea this package existed at the time, so thank you for mentioning it!

(On the plus side, I am glad I discovered it, since its "codeprose" was a joy to read. On the minus side, now I have a permanent TODO item in my .emacs asking me to review diminish, dim, rich-minority and delight to figure out which one is "optimal", whatever that's supposed to mean)

@purcell
Copy link
Owner

purcell commented May 19, 2017

On the minus side, now I have a permanent TODO item in my .emacs asking me to review diminish, dim, rich-minority and delight to figure out which one is "optimal", whatever that's supposed to mean)

Haha, I know that feeling. But if you don't know why you need anything but diminish, then diminish is probably all you need. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants