Skip to content

Whitespace differences not shown in diff views (e.g. in Magit) #162

Open
@lckarssen

Description

Thanks for the nice looking themes! I have been using the eighties version for the past week and ran into the following: in Magit's diff views white space differences are not visible. It looks like this is caused by the fact that the themes set a foreground colour instead of (or in addition to) a background colour.

For example, here is the output of describe-face for the default Emacs theme (with the point at a space I inserted):

Face: diff-refine-added (sample) (customize this face)

Documentation:
Face used for added characters shown by ‘diff-refine-hunk’.

Defined in ‘diff-mode.el’.


           Family: unspecified
          Foundry: unspecified
            Width: unspecified
           Height: unspecified
           Weight: unspecified
            Slant: unspecified
       Foreground: unspecified
DistantForeground: unspecified
       Background: #bbffbb
        Underline: unspecified
         Overline: unspecified
   Strike-through: unspecified
              Box: unspecified
          Inverse: unspecified
          Stipple: unspecified
             Font: unspecified
          Fontset: unspecified
           Extend: unspecified
          Inherit: diff-refine-changed

  This face was introduced, or its default value was changed, in
  version 24.3 of Emacs.

Here is the same info for the tomorrow-blue theme:

Face: diff-refine-added (sample) (customize this face)

Documentation:
Face used for added characters shown by ‘diff-refine-hunk’.

Defined in ‘diff-mode.el’.


           Family: unspecified
          Foundry: unspecified
            Width: unspecified
           Height: unspecified
           Weight: unspecified
            Slant: unspecified
       Foreground: #99ffff
DistantForeground: unspecified
       Background: unspecified
        Underline: unspecified
         Overline: unspecified
   Strike-through: unspecified
              Box: unspecified
          Inverse: unspecified
          Stipple: unspecified
             Font: unspecified
          Fontset: unspecified
           Extend: unspecified
          Inherit: unspecified

  This face was introduced, or its default value was changed, in
  version 24.3 of Emacs.

I have tried the blue, eighties and night versions.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions