allow palette overrides #204

digitalkaoz · 2017-03-11T00:32:45Z

this PR allows overriding palettes

houndci-bot · 2017-03-11T00:32:50Z

src/scss/dependencies/_variables.scss

+  $picker-primary-text-theme-color: $color-primary-text!default;
+  $picker-secondary-text-theme-color: $color-secondary-text!default;
+  $picker-circle-color: $palette-grey-700!default;
+  $picker-line-color: $palette-primary-200!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:50Z

src/scss/dependencies/_variables.scss

+  $md-button-color--disabled: $color-hint-text!default;
+  $picker-primary-text-theme-color: $color-primary-text!default;
+  $picker-secondary-text-theme-color: $color-secondary-text!default;
+  $picker-circle-color: $palette-grey-700!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:50Z

src/scss/dependencies/_variables.scss

+  $md-button-color--active: $palette-grey-600!default;
+  $md-button-color--disabled: $color-hint-text!default;
+  $picker-primary-text-theme-color: $color-primary-text!default;
+  $picker-secondary-text-theme-color: $color-secondary-text!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:50Z

src/scss/dependencies/_variables.scss

+  $md-button-color--focus: $palette-grey-700!default;
+  $md-button-color--active: $palette-grey-600!default;
+  $md-button-color--disabled: $color-hint-text!default;
+  $picker-primary-text-theme-color: $color-primary-text!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:50Z

src/scss/dependencies/_variables.scss

+  $md-button-color: $palette-primary-200!default;
+  $md-button-color--focus: $palette-grey-700!default;
+  $md-button-color--active: $palette-grey-600!default;
+  $md-button-color--disabled: $color-hint-text!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:51Z

src/scss/dependencies/_variables.scss

-  $picker-line-color: $palette-primary-200;
+  $picker-header-color: $palette-grey-700!default;
+  $picker-body-color: $palette-grey-800!default;
+  $picker-button-left:'../images/ic_keyboard_arrow_left_white_24px.svg'!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:51Z

src/scss/dependencies/_variables.scss

-  $picker-circle-color: $palette-grey-700;
-  $picker-line-color: $palette-primary-200;
+  $picker-header-color: $palette-grey-700!default;
+  $picker-body-color: $palette-grey-800!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:51Z

src/scss/dependencies/_variables.scss

-  $picker-secondary-text-theme-color: $color-secondary-text;
-  $picker-circle-color: $palette-grey-700;
-  $picker-line-color: $palette-primary-200;
+  $picker-header-color: $palette-grey-700!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:51Z

src/scss/dependencies/_global.scss


 //accent color palette
-$accent-color-palette: $palette-lime;
+$accent-color-palette: $palette-lime!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:32:51Z

src/scss/dependencies/_global.scss


 //primary color palette
-$primary-color-palette: $palette-teal;
+$primary-color-palette: $palette-teal!default;


! should be preceded by a space, and should not be followed by a space

houndci-bot · 2017-03-11T00:37:35Z

src/scss/dependencies/_variables.scss

-$shadow-ambient-shadow-opacity: 0.12 !default;
+$shadow-key-umbra-opacity: .2 !default;
+$shadow-key-penumbra-opacity: .14 !default;
+$shadow-ambient-shadow-opacity: .12 !default;


.12 should be written with a leading zero as 0.12

houndci-bot · 2017-03-11T00:37:35Z

src/scss/dependencies/_variables.scss

-$shadow-key-penumbra-opacity: 0.14 !default;
-$shadow-ambient-shadow-opacity: 0.12 !default;
+$shadow-key-umbra-opacity: .2 !default;
+$shadow-key-penumbra-opacity: .14 !default;


.14 should be written with a leading zero as 0.14

houndci-bot · 2017-03-11T00:37:35Z

src/scss/dependencies/_variables.scss

-$shadow-key-umbra-opacity: 0.2 !default;
-$shadow-key-penumbra-opacity: 0.14 !default;
-$shadow-ambient-shadow-opacity: 0.12 !default;
+$shadow-key-umbra-opacity: .2 !default;


.2 should be written with a leading zero as 0.2

houndci-bot · 2017-03-11T00:37:35Z

src/scss/dependencies/_variables.scss

+  $picker-button-left: $picker-images-base-path + 'ic_keyboard_arrow_left_white_24px.svg' !default;
+  $picker-button-right: $picker-images-base-path + 'ic_keyboard_arrow_right_white_24px.svg' !default;
+  $picker-button-left-disabled: $picker-images-base-path + 'ic_keyboard_arrow_left_white_disabled_24px.svg' !default;
+  $picker-button-right-disabled: $picker-images-base-path + 'ic_keyboard_arrow_right_white_disabled_24px.svg' !default;


Prefer double-quoted strings

houndci-bot · 2017-03-11T00:37:35Z

src/scss/dependencies/_variables.scss

+  $picker-body-color: $palette-grey-800 !default;
+  $picker-button-left: $picker-images-base-path + 'ic_keyboard_arrow_left_white_24px.svg' !default;
+  $picker-button-right: $picker-images-base-path + 'ic_keyboard_arrow_right_white_24px.svg' !default;
+  $picker-button-left-disabled: $picker-images-base-path + 'ic_keyboard_arrow_left_white_disabled_24px.svg' !default;


Prefer double-quoted strings

houndci-bot · 2017-03-11T00:37:36Z

src/scss/dependencies/_variables.scss

@@ -50,13 +50,15 @@ $palette-accent-900: nth($accent-color-palette, 10);

 //theme dependent items

+$picker-images-base-path: '../images/' !default;


Prefer double-quoted strings

houndci-bot · 2017-03-11T00:37:36Z

src/scss/dependencies/_variables.scss

+$color-primary-text: rgb(255, 255, 255);
+$color-secondary-text: rgba(255, 255, 255, .7);
+$color-hint-text: rgba(255, 255, 255, .3);
+$color-disabled-text: rgba(255, 255, 255, .12);


.12 should be written with a leading zero as 0.12

houndci-bot · 2017-03-11T00:37:36Z

src/scss/dependencies/_variables.scss

-$color-disabled-text: rgba(255,255,255,0.12);
+$color-primary-text: rgb(255, 255, 255);
+$color-secondary-text: rgba(255, 255, 255, .7);
+$color-hint-text: rgba(255, 255, 255, .3);


.3 should be written with a leading zero as 0.3

houndci-bot · 2017-03-11T00:37:36Z

src/scss/dependencies/_variables.scss

-$color-hint-text: rgba(255,255,255,0.3);
-$color-disabled-text: rgba(255,255,255,0.12);
+$color-primary-text: rgb(255, 255, 255);
+$color-secondary-text: rgba(255, 255, 255, .7);


.7 should be written with a leading zero as 0.7

houndci-bot · 2017-03-11T00:37:36Z

src/scss/dependencies/_variables.scss

+$color-primary-dark-text: rgba(0, 0, 0, .87);
+$color-secondary-dark-text: rgba(0, 0, 0, .54);
+$color-hint-dark-text: rgba(0, 0, 0, .26);
+$color-disabled-dark-text: rgba(0, 0, 0, .12);


.12 should be written with a leading zero as 0.12

puranjayjain · 2017-03-11T05:27:18Z

thanks again @digitalkaoz

digitalkaoz · 2017-03-11T06:22:54Z

@puranjayjain can you tag a minor Release please?

houndci-bot reviewed Mar 11, 2017

View reviewed changes

digitalkaoz force-pushed the feature/scss_overrides branch from b76e3ce to b16a0e1 Compare March 11, 2017 00:37

houndci-bot reviewed Mar 11, 2017

View reviewed changes

digitalkaoz force-pushed the feature/scss_overrides branch from b16a0e1 to 0862218 Compare March 11, 2017 00:38

allow palette overrides

899a3eb

digitalkaoz force-pushed the feature/scss_overrides branch from 0862218 to 899a3eb Compare March 11, 2017 00:40

puranjayjain merged commit 5dec104 into puranjayjain:master Mar 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow palette overrides #204

allow palette overrides #204

digitalkaoz commented Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

houndci-bot Mar 11, 2017

puranjayjain commented Mar 11, 2017

digitalkaoz commented Mar 11, 2017

		@@ -50,13 +50,15 @@ $palette-accent-900: nth($accent-color-palette, 10);

		//theme dependent items

		$picker-images-base-path: '../images/' !default;

allow palette overrides #204

allow palette overrides #204

Conversation

digitalkaoz commented Mar 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

puranjayjain commented Mar 11, 2017

digitalkaoz commented Mar 11, 2017