-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PETBUILD_GTK to _00build.conf #2532
Move PETBUILD_GTK to _00build.conf #2532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my perspective.
there's only a few gtkdialog apps that i kept as gtk2 as i found gtk3 problematic with them. everything else is gtk3 |
Can you open a PR that makes these problematic apps use gtk2dialog? |
@mrfricks I forced pMusic to use gtk2, perhaps you could do something similar for the gtkdialog apps you need to run with gtk2. (see |
i can do a PR for samba in petbuilds but for quicksetup i actually just used fossapups version as just running it with gtk2dialog doesn't solve the selection list issue. as for the PPM i use an older version so a PR wouldn't be appropriate ... unless it is a complete roll back to the last good working version :) #2186 @01micko yes i have done that with a few apps. most are working well with gtk3 though and look nicer. |
Well let's merge then 😃 |
This will be useful if: