Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PETBUILD_GTK to _00build.conf #2532

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

dimkr
Copy link
Contributor

@dimkr dimkr commented Sep 30, 2021

This will be useful if:

  1. @mrfricks decides to use GTK+ 2 to make his next Puppy closer to FossaPup 9.5 (https://forum.puppylinux.com/viewtopic.php?f=40&t=4138)
  2. @peabee wants to use GTK+ 2 in a 64-bit build not based on an old distro like Ubuntu 18.04; the automatic PETBUILD_GTK choice logic in petbuilds.sh (what we have today) will pick GTK+ 3
  3. @01micko decides to stick with GTK+ 2 for Slacko 8.x, and deal with GTK+ 3 related issues later, possibly in a point release
  4. I want to build a "lite" or "barebones" 64-bit flavor of dpup that uses the lighter GTK+ 2

Copy link
Contributor

@01micko 01micko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective.

@mrfricks
Copy link
Contributor

mrfricks commented Oct 1, 2021

there's only a few gtkdialog apps that i kept as gtk2 as i found gtk3 problematic with them.
they are quicksetup (i found selecting the timezone a chore), samba simple management (doesn't display properly) and the PPM (i use an older version that works well but gtk3 removes various install & info bars)

everything else is gtk3

@dimkr
Copy link
Contributor Author

dimkr commented Oct 1, 2021

there's only a few gtkdialog apps that i kept as gtk2 as i found gtk3 problematic with them. they are quicksetup (i found selecting the timezone a chore), samba simple management (doesn't display properly) and the PPM (i use an older version that works well but gtk3 removes various install & info bars)

Can you open a PR that makes these problematic apps use gtk2dialog?

@01micko
Copy link
Contributor

01micko commented Oct 1, 2021

@mrfricks I forced pMusic to use gtk2, perhaps you could do something similar for the gtkdialog apps you need to run with gtk2. (see rootfs-packages/pmusic).

@mrfricks
Copy link
Contributor

mrfricks commented Oct 1, 2021

i can do a PR for samba in petbuilds but for quicksetup i actually just used fossapups version as just running it with gtk2dialog doesn't solve the selection list issue.

as for the PPM i use an older version so a PR wouldn't be appropriate ... unless it is a complete roll back to the last good working version :) #2186

@01micko yes i have done that with a few apps. most are working well with gtk3 though and look nicer.

@01micko
Copy link
Contributor

01micko commented Oct 1, 2021

Well let's merge then 😃

@01micko 01micko merged commit 7b9bc6b into puppylinux-woof-CE:testing Oct 1, 2021
@dimkr dimkr deleted the feature/gtk-2-or-3-choice branch October 1, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants