add link to discussion about the 'bash' meson build option #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkr
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
I don't think this warning is needed, because the bash feature set is a superset of the features of /bin/sh (dash, ash or whatever). If a script that uses gtkdialog works with -Dbash=false, it will work with -Dbash=true, but it's the opposite that can break stuff (a script with bashisms, when gtkdialog is built with -Dbash=false).
Maybe warn when building with -Dbash=false, on a distro where /bin/sh is not a symlink to bash, and warn at build time?
(But, with all that said - I don't oppose this PR. I'll keep building with -Dbash=true for my use case.)
01micko
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.