(maint) remove dependency on stylefruits/gniazdo #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a suggestion in the gniazdo project https://github.com/stalefruits/gniazdo#usage this was updated to use https://github.com/gnarroway/hato instead of stylefruits, which requires it to drop support of jdk8 for testing.
Contributor
|
I'm confused about how this and #244 play together. |
Contributor
Author
|
It is an alternative, and eliminates jdk8 testing. Seemed like #244 would be safer to introduce earlier. |
Contributor
|
We can't drop support for jdk8 in Puppet 7, so idk if we want this right now. Maybe something to ticket and come back to for Puppet 8? |
Contributor
Author
|
It technically doesn't drop support for jdk8, just drops testing of this project in jdk8. |
Contributor
Author
|
And yes, it is something we should revisit. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a suggestion in the gniazdo project https://github.com/stalefruits/gniazdo#usage this was updated to use https://github.com/gnarroway/hato instead of stylefruits, which requires it to drop support of jdk8 for testing.