Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PCP-239) remove Makefile & update build instructions #321

Merged
merged 1 commit into from
Feb 5, 2016
Merged

(PCP-239) remove Makefile & update build instructions #321

merged 1 commit into from
Feb 5, 2016

Conversation

mruzicka
Copy link
Contributor

@mruzicka mruzicka commented Feb 4, 2016

Removing Makefile as it was single purpose, broken and as such confusing.
Instead including build instructions in the README.md.

Initial Setup
-------------

Note: Testing custom facts requires Ruby 1.9+ with libruby built as a dynamic library; that often implies development builds of Ruby.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facter stuff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, removed

Removing Makefile as it was single purpose, broken and as such confusing.
Instead including build instructions in the README.md.

[skip ci]
@parisiale
Copy link
Contributor

👍
In PCP-278 we will ensure that the described process is conform to the puppet-agent one.

parisiale added a commit that referenced this pull request Feb 5, 2016
(PCP-239) remove Makefile & update build instructions
@parisiale parisiale merged commit 5b8ffc9 into puppetlabs:master Feb 5, 2016
@mruzicka mruzicka deleted the PCP-244_remove_Makfefiles branch February 9, 2016 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants