Git: Short SHA performance

[giggsey]

Use Case

There is also an optimisation if the cloned repo is at the correct revision: https://github.com/puppetlabs/puppetlabs-vcsrepo/blob/main/lib/puppet/provider/vcsrepo/git.rb#L529-L532 introduced in #380

But this only works with full SHAs.

When the SHA isn't an exact match, a git fetch is run, which can potentially be slow for large repos

Describe the Solution You Would Like

git rev-parse HEAD is used to get the current commit for use in comparison, which returns the full sha.

Could that command change to git rev-parse --short={@resource.value(:revision).length} HEAD for the comparison?

This would then match, and not bother with the rest of the get_revision function.

[chelnak]

Hey @giggsey thanks for this. It's a solid suggestion.

I'll do some testing with the updated command in the description and see what comes up.

In the meantime - if you have already implemented this, a PR would be welcome. We could work with you to get it merged.

[github-actions]

Hello! 👋

This issue has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which issues need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the issue with a comment.

[giggsey]

Completed?

[LukasAud]

Sorry, this was marked as inactive and closed by our outdated automated system some time ago. We no longer close inactive issues based on inactivity without confirmation. Re-opening this issue.