[CAT-1382] : Fixing CI failure due to rubocop #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Sep 11, 2023
.rubocop_todo.yml
Outdated
Comment on lines
119
to
120
| - 'spec/unit/puppet/provider/file_line/ruby_spec_alter.rb' | ||
| - 'spec/unit/puppet/provider/file_line/ruby_spec_use_cases.rb' |
There was a problem hiding this comment.
Please fix these instead by renaming the files. They are tests that don't get executed.
There was a problem hiding this comment.
Thanks for the comment @ekohl
I have done the requested changes, please do have a look.
Ramesh7
force-pushed
the
CAT-1382-Fix-CI-Pipeline
branch
2 times, most recently
from
a6d94fc to
fa474ff
Compare
rajat-puppet
force-pushed
the
CAT-1382-Fix-CI-Pipeline
branch
from
fa474ff to
eaf830f
Compare
rajat-puppet
requested review from
alexjfisher,
b4ldr,
bastelfreak,
smortex,
seanmil and
a team
as code owners
Ramesh7
approved these changes
Sep 12, 2023
rajat-puppet
force-pushed
the
CAT-1382-Fix-CI-Pipeline
branch
from
4c9ec5d to
d32162b
Compare
ekohl
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing CI failure due to rubocop
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)