Modernise has_interface_with function
#1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
requested review from
a team,
b4ldr,
bastelfreak,
ekohl and
smortex
as code owners
has_interface_with is a functionBreaking changes to this file MAY impact these 8 modules (near match):stdlib::has_interface_with is a functionthat may have no external impact to Forge modules. This module is declared in 318 of 580 indexed public
|
ekohl
reviewed
Apr 25, 2023
Convert the function to the modern function API as a namespaced function and use the `networking` fact instead of legacy facts. A non-namespaced shim is also created (but marked deprecated), to preserve compatibility.
bastelfreak
approved these changes
Apr 26, 2023
ekohl
approved these changes
Apr 26, 2023
jordanbreen28
approved these changes
Apr 27, 2023
Contributor
jordanbreen28
left a comment
jordanbreen28
left a comment
There was a problem hiding this comment.
Nice job @alexjfisher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the function to the modern function API as a namespaced function and use the
networkingfact instead of legacy facts.A non-namespaced shim is also created (but marked deprecated), to preserve compatibility.