Skip to content

Remove deprecated type and type3x functions #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

MartyEwings
Copy link
Contributor

Type was deprecated in Puppet4, and type3x was to remain until Puppet 3 support was dropped, this PR removes them and their unit tests

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2023

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

type is a function

Breaking changes to this file MAY impact these 18 modules (near match):

type3x is a function

Breaking changes to this file MAY impact these 11 modules (near match):

This module is declared in 318 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud
Copy link
Contributor

Nice one. However, any reviewers please refrain from merging just yet until we can cut a regular release with all bugfixes/features up to date. We probably dont want deprecated function removals included in a pre-release.

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit f95e1d9 into puppetlabs:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants