(PA-7222) Add Amazon FIPS 2023 (x86_64) support in task acceptance tests

[shubhamshinde360]

This commit adds Amazon FIPS 2023 (x86_64) support to task acceptance tests. Support for puppet7 to puppet8 upgrade tests has not been added since puppet7 is EOL and its packages were not built for the platform.

[shubhamshinde360]

Hi @bastelfreak, @joshcooper
Could you please take a look at this. Thanks!

[joshcooper]

@shubhamshinde360 could you update your commit message to describe what this change is doing? It's somewhat unexpected that we're "adding support" for this new platform, by skipping the upgrade test (since there isn't a previous version to upgrade from). Were there really no other changes needed for Amazon 2023 FIPS?

[shubhamshinde360]

Thanks @joshcooper,
I updated the commit message to specify that we're adding support for only task acceptance tests in this PR and not upgrade tests since we don't have puppet 7 builds to upgrade from. Let me know what you think.

[joshcooper]

If you haven't already, could you verify that the task acceptance tests pass with this change? The test already installs "latest_sources" from artifactory, since we point yum_source there:

puppetlabs-puppet_agent/task_spec/spec/acceptance/init_spec.rb

Lines 53 to 72 in 14b1844

	def latest_sources
	{
	'yum_source' => 'https://artifactory.delivery.puppetlabs.net:443/artifactory/internal_nightly__local/yum',
	'apt_source' => 'https://artifactory.delivery.puppetlabs.net:443/artifactory/internal_nightly__local/apt',
	'mac_source' => 'https://artifactory.delivery.puppetlabs.net:443/artifactory/internal_nightly__local/downloads',
	'windows_source' => 'https://artifactory.delivery.puppetlabs.net:443/artifactory/internal_nightly__local/downloads',
	}
	end
	it 'works with version and install tasks' do
	case target_platform
	when latest_platform_list
	# Here we only install puppet-agent 8.x from nightlies as we don't support 7.x
	# We have to consider tests to upgrade puppet 8.x to latest nightlies in future
	# Install an puppet8 nightly version
	results = run_task('puppet_agent::install', 'target', { 'collection' => 'puppet8-nightly',
	'version' => 'latest',
	'stop_service' => true }.merge(latest_sources))

[shubhamshinde360]

Yes, Josh. I have already tested the task acceptance tests as part of https://perforce.atlassian.net/wiki/spaces/AGENT/pages/369365152/How+to+add+a+platform+for+puppet-agent#Howtoaddaplatformforpuppet-agent-3.Updatepuppet_agentmoduletaskacceptancepe_puppet_agent

➜  task_spec git:(PA-7222) ✗ bundle exec rake task_acceptance
/Users/shubham.shinde/.rbenv/versions/3.1.0/bin/ruby -I/Users/shubham.shinde/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/rspec-core-3.13.3/lib:/Users/shubham.shinde/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/rspec-support-3.13.2/lib /Users/shubham.shinde/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/rspec-core-3.13.3/exe/rspec --pattern spec/acceptance/\*\*/\*_spec.rb
/Users/shubham.shinde/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/beaker-rspec-8.2.0/lib/beaker-rspec/helpers/serverspec.rb:39: warning: already initialized constant Module::VALID_OPTIONS_KEYS
/Users/shubham.shinde/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/specinfra-2.92.0/lib/specinfra/configuration.rb:4: warning: previous definition of VALID_OPTIONS_KEYS was here
Beaker::Hypervisor, found some abs boxes to create
Requesting VMs with job_id: shubham.shinde-1743660383004 Will retry for up to an hour.
Waiting 1s (x1) Total: 0 / 1
Waiting 2s (x2) Total: 0 / 1
Waiting 3s (x3) Total: 0 / 1
Waiting 4s (x4) Total: 0 / 1
Waiting 5s (x5) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
Waiting 6s (x6) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
Waiting 7s (x7) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
Waiting 8s (x8) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
Waiting 9s (x9) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
Waiting 10s (x10) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
Waiting 10s (x11) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
Waiting 10s (x12) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
Waiting 10s (x13) Total: 0 / 1, AWS: amazonfips-2023-x86_64 (ready: 0, pending: 1)
  Warning: Skipping ip method to ssh to host as its value is not set. Refer to https://github.com/puppetlabs/beaker/tree/master/docs/how_to/ssh_connection_preference.md to remove this warning
verify_host_key: false is deprecated, use :never
  Warning: Skipping ip method to ssh to host as its value is not set. Refer to https://github.com/puppetlabs/beaker/tree/master/docs/how_to/ssh_connection_preference.md to remove this warning
verify_host_key: false is deprecated, use :never
Disabling updates.puppetlabs.com by modifying hosts file to resolve updates to 127.0.0.1 on ip-10-227-7-123.amz-dev.puppet.net

install task
Installed puppet-agent on ip-10-227-7-123.amz-dev.puppet.net: success
  works with version and install tasks

Finished in 39.1 seconds (files took 2 minutes 13.7 seconds to load)
1 example, 0 failures

➜  task_spec git:(PA-7222) ✗