Skip to content

[Fix #703] use 'type' instead of 'which' for increased portability #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

[Fix #703] use 'type' instead of 'which' for increased portability #704

merged 1 commit into from
Feb 29, 2024

Conversation

zbentley
Copy link
Contributor

Fixes #703 by using the type shell builtin instead of the (maybe not installed) which binary.

@zbentley zbentley requested review from bastelfreak and a team as code owners February 27, 2024 20:15
@CLAassistant
Copy link

CLAassistant commented Feb 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mhashizume mhashizume added the enhancement New feature or request label Feb 29, 2024
@mhashizume
Copy link
Contributor

Zac! Thanks for the PR

@mhashizume mhashizume merged commit 4d148c4 into puppetlabs:main Feb 29, 2024
@zbentley
Copy link
Contributor Author

From one Bearcat to another, thanks @mhashizume!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@mhashizume mhashizume mhashizume approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install task incorrectly identifies Puppet as not installed on target hosts missing the which program.
4 participants
@zbentley @CLAassistant @mhashizume @kenyon