(PA-5820) Correct parameter types #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
added
the
maintenance
mhashizume
force-pushed
the
PA-5820/main/data-type-corrections
branch
2 times, most recently
from
ba0fa4e to
a0833de
Compare
joshcooper
reviewed
Sep 29, 2023
mhashizume
force-pushed
the
PA-5820/main/data-type-corrections
branch
from
a0833de to
7893bb6
Compare
Previously, 74e022d erroneously typed the $package_version and $install_options parameters as Optional. This commit updates those parameters to be required, and gives a more specific type to $install_options.
mhashizume
force-pushed
the
PA-5820/main/data-type-corrections
branch
from
7893bb6 to
1bd111b
Compare
joshcooper
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
I verified I could retrieve environment classes and their parameters using:
curl -sf -k --cert cert.pem --key key.pem -X GET -H 'Accept: application/json' 'https://xxx:8140/puppet/v3/environment_classes?environment=production'
and all of the resulting class parameters have a "type"
mhashizume
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, 74e022d erroneously typed the $package_version and $install_options parameters as Optional.
This commit updates those parameters to be required, and gives a more specific type to $install_options.