Ensure that data_directory is set in the config. #510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user specifies an alternate data directory by using the $datadir variable, it is respected by the initdb class but isn't set in the configuration before starting the server. This change fixes that.
|
maybe we should add this to the test-set? |
|
Looks valid. Could you write an acceptance test for alternate data directories? |
|
There is another pull request that causes the service to stop before trying to change the datadir, #514, maybe some collaboration could happen? |
|
Closing in favor of #514 . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that setting $datadir for postgresql::server actually does what I'd expect.