Skip to content

maint: removing debian 12 from metadata #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

malikparvez
Copy link
Member

@malikparvez malikparvez commented Jul 25, 2023

Partially reverts #1460

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do a partial revert and only remove it from metadata.json?

@bastelfreak
Copy link
Collaborator

why does it need to be reverted? It works fine on Debian 12.

@malikparvez
Copy link
Member Author

@ekohl yes that might work, thanks for the suggestion

@malikparvez malikparvez force-pushed the revert-1460-bookworm branch from 7bfd413 to 99870b6 Compare July 26, 2023 10:06
@malikparvez malikparvez changed the title Revert "Add Debian 12 compatibility" maint: removing debian 12 from metadata Jul 26, 2023
@SimonHoenscheid
Copy link
Collaborator

SimonHoenscheid commented Jul 26, 2023

What's the reason to remove the Debian 12 support?

@ekohl
Copy link
Collaborator

ekohl commented Jul 26, 2023

I think it's fair if it isn't tested in acceptance tests (which right now it isn't).

@malikparvez
Copy link
Member Author

@bastelfreak as mentioned by @ekohl because it was not being tested as right now we don't support debian 12

@jordanbreen28 jordanbreen28 merged commit 823f0b1 into main Jul 26, 2023
@jordanbreen28 jordanbreen28 deleted the revert-1460-bookworm branch July 26, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants