-
Notifications
You must be signed in to change notification settings - Fork 614
MODULES-11049 - Implement default privileges changes #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
postgresql::server::default_privileges is a typethat may have no external impact to Forge modules. This module is declared in 70 of 576 indexed public
|
Thanks @mtancoigne for your contribution. The tests are failing on some OS with the following error The default version on each OS is given here https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/manifests/globals.pp#L167 We may have to restrict the tests not to run on those OSes which have defaults <9.6 |
Good to know, thank you, i'll update the PR! |
Thanks @mtancoigne for updating the tests. The unit tests are failing. |
b2e3f7d
to
ba8c9f4
Compare
I updated the tests and will squash the commits once it's all green. |
Thanks @mtancoigne for the changes. Tested for different object types and its looking good. As you have mentioned, could you please update the document for this new feature. Great work.Thank you. |
You're welcome, I'll try to update documentation as soon as possible this week. |
ba8c9f4
to
f9bfba7
Compare
README was updated and commits were squashed. |
@@ -0,0 +1,144 @@ | |||
define postgresql::server::default_privileges ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the summary and parameter details which will help with autogenerating REFERENCE.md file prior to each release.
For example
https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/manifests/server/database_grant.pp#L1
https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/REFERENCE.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, i'll do it this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks alot @mtancoigne for incorporating the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done.
f9bfba7
to
c96b073
Compare
Thank you @mtancoigne for your contribution. |
# frozen_string_literal: true | ||
|
||
require 'spec_helper' | ||
require 'spec_helper_acceptance' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. A unit test should not include the acceptance helper and has broken the test suite further than it already was.
Following the feature request, this PR allow to grant or revoke default privileges on objects in a schema.
I still have to update the documentation.