Skip to content

Use Data Types to verify ensure #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Aug 10, 2020

This makes the API clear and the code simpler.

This makes the API clear and the code simpler.
@ekohl ekohl requested a review from a team as a code owner August 10, 2020 09:54
@puppet-community-rangefinder
Copy link

postgresql::server::config_entry is a type

Breaking changes to this file WILL impact these 5 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 71 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan david22swan changed the base branch from master to main August 11, 2020 16:55
@david22swan
Copy link
Member

@ekohl
Making a quick change to point your PR at the newly default main branch.
Apologies if this is inconvenient in any way.

@ekohl
Copy link
Collaborator Author

ekohl commented Aug 12, 2020

Looks like 2 acceptance tests failed due to timeouts, not actual failures. I can't restart them due to permissions.

@sanfrancrisko
Copy link
Contributor

Have attempted to re-run the tests but we still hit the time out issue. One last re-run but the release checks pass against our internal infrastructure:

┌ [✔] Running against 21 targets.
├── [✔] choppy-copy.delivery.puppetlabs.net, redhat-5-x86_64
├── [✔] inexorable-film.delivery.puppetlabs.net, redhat-6-x86_64
├── [✔] avid-television.delivery.puppetlabs.net, redhat-7-x86_64
├── [✔] great-feast.delivery.puppetlabs.net, redhat-8-x86_64
├── [✔] classic-eraser.delivery.puppetlabs.net, centos-5-x86_64
├── [✔] noisier-cider.delivery.puppetlabs.net, centos-6-x86_64
├── [✔] willing-stray.delivery.puppetlabs.net, centos-7-x86_64
├── [✔] waxen-colon.delivery.puppetlabs.net, centos-8-x86_64
├── [✔] nude-primitive.delivery.puppetlabs.net, oracle-5-x86_64
├── [✔] actuarial-forma.delivery.puppetlabs.net, oracle-6-x86_64
├── [✔] fewer-grease.delivery.puppetlabs.net, oracle-7-x86_64
├── [✔] fancy-sunshield.delivery.puppetlabs.net, scientific-6-x86_64
├── [✔] casual-lodgment.delivery.puppetlabs.net, scientific-7-x86_64
├── [✔] slow-linking.delivery.puppetlabs.net, debian-8-x86_64
├── [✔] viable-parade.delivery.puppetlabs.net, debian-9-x86_64
├── [✔] waxen-merit.delivery.puppetlabs.net, debian-10-x86_64
├── [✔] belgian-farce.delivery.puppetlabs.net, sles-12-x86_64
├── [✔] acoustical-rum.delivery.puppetlabs.net, ubuntu-1404-x86_64
├── [✔] naive-calfskin.delivery.puppetlabs.net, ubuntu-1604-x86_64
├── [✔] supreme-nonstop.delivery.puppetlabs.net, ubuntu-1804-x86_64
└── [✔] famed-designing.delivery.puppetlabs.net, ubuntu-2004-x86_64
================

@sanfrancrisko sanfrancrisko merged commit 438748c into puppetlabs:main Aug 14, 2020
@ekohl ekohl deleted the formalize-api branch February 16, 2021 12:45
cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants