Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d1c174e
Choose a base ref
...
head repository: puppetlabs/puppetlabs-postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bc60361
Choose a head ref
  • 17 commits
  • 45 files changed
  • 6 contributors

Commits on Jan 11, 2021

  1. Use OS major version numbers in globals

    This is a code simplification for distributions that don't change the
    PostgreSQL version in a major release. As a bonus fact, it adds support
    for CentOS 8 Stream which identifies itself without a minor version.
    
    For completeness, the OS facts from CentOS 8 Stream:
    
        # facter os
        {
          architecture => "x86_64",
          family => "RedHat",
          hardware => "x86_64",
          name => "CentOS",
          release => {
            full => "8",
            major => "8"
          },
          selinux => {
            enabled => false
          }
        }
    ekohl committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    3a56540 View commit details
    Browse the repository at this point in the history
  2. Remove redundant selector for Archlinux

    Both branches of the selector have the same version so it's redundant.
    ekohl committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    0e7dca8 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. (maint) Update github actions

    DavidS committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    1ef50d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Fix postgresql::sql task when password is not set

    When password is not set, `{ 'PGPASSWORD' => password } unless
    password.nil?` evaluates to `nil`, setting `env_hash` to `nil`.
    
    `nil` is then passed as the first argument of `Open3.capture3` which
    result in an exception:
    
    ```
    /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:213:in `spawn': no implicit conversion of nil into String (TypeError)
    	from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:213:in `popen_run'
    	from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:101:in `popen3'
    	from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:281:in `capture3'
    	from /opt/puppetlabs/mcollective/tasks-spool/899e9e0635bb53f1a09b4716548ff69f/files/sql.rb:13:in `get'
    	from /opt/puppetlabs/mcollective/tasks-spool/899e9e0635bb53f1a09b4716548ff69f/files/sql.rb:27:in `<main>'
    ```
    
    Make sure `env_hash` is always a hash to fix this issue.
    smortex committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    b852434 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Merge pull request #1225 from ekohl/use-major-version

    Clean up globals logic to support CentOS 8 stream
    sheenaajay authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    15c8728 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1226 from smortex/fix-task

    Fix postgresql::sql task when password is not set
    sheenaajay authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    7d965b9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1229 from puppetlabs/pdksync_gha-updates

    pdksync - Update gha templates
    DavidS authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    07d9965 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1b44ad0 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1231 from sheenaajay/disablecentos8

    (IAC-1136) Back out CentOS 8 tests on TravisCI
    sanfrancrisko authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    fe93ba9 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Configuration menu
    Copy the full SHA
    4a06537 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Merge pull request #1230 from sheenaajay/bug/1201/systemd

    (bug) reload the service after the deletion of old unit file
    DavidS authored Feb 5, 2021
    Configuration menu
    Copy the full SHA
    3c6e00e View commit details
    Browse the repository at this point in the history
  2. Also perform systemd daemon-reload on Puppet 6.1+

    The way daemon-reload is implemented in Puppet 6.1 is by calling
    
        systemctl show --property=NeedDaemonReload -- $SERVICE
    
    If that returns yes then it performs systemctl daemon-reload. However,
    this doesn't work reliable because of the particular case.
    
        # systemctl show --property=NeedDaemonReload -- postgresql
        Failed to get properties: Access denied
    
    This is probably because the original unit file is removed.
    ekohl committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    3d47832 View commit details
    Browse the repository at this point in the history
  3. Move the Template uses comment to the actual template

    This moves it so it's closer to the actual call to template()
    ekohl committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    18e7cf6 View commit details
    Browse the repository at this point in the history
  4. Improve systemctl daemon-reload comment wording

    Co-authored-by: Evgeni Golov <evgeni@golov.de>
    ekohl and evgeni authored Feb 5, 2021
    Configuration menu
    Copy the full SHA
    75cdb52 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1233 from ekohl/fix-systemd-reload

    Also perform systemd daemon-reload on Puppet 6.1+
    sheenaajay authored Feb 5, 2021
    Configuration menu
    Copy the full SHA
    8498326 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Configuration menu
    Copy the full SHA
    88b6342 View commit details
    Browse the repository at this point in the history
  2. (maint) pdk update

    sheenaajay committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    bc60361 View commit details
    Browse the repository at this point in the history
Loading