-
Notifications
You must be signed in to change notification settings - Fork 612
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-postgresql
base: d1c174e
head repository: puppetlabs/puppetlabs-postgresql
compare: bc60361
- 17 commits
- 45 files changed
- 6 contributors
Commits on Jan 11, 2021
-
Use OS major version numbers in globals
This is a code simplification for distributions that don't change the PostgreSQL version in a major release. As a bonus fact, it adds support for CentOS 8 Stream which identifies itself without a minor version. For completeness, the OS facts from CentOS 8 Stream: # facter os { architecture => "x86_64", family => "RedHat", hardware => "x86_64", name => "CentOS", release => { full => "8", major => "8" }, selinux => { enabled => false } }
Configuration menu - View commit details
-
Copy full SHA for 3a56540 - Browse repository at this point
Copy the full SHA 3a56540View commit details -
Remove redundant selector for Archlinux
Both branches of the selector have the same version so it's redundant.
Configuration menu - View commit details
-
Copy full SHA for 0e7dca8 - Browse repository at this point
Copy the full SHA 0e7dca8View commit details
Commits on Jan 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1ef50d2 - Browse repository at this point
Copy the full SHA 1ef50d2View commit details
Commits on Jan 28, 2021
-
Fix postgresql::sql task when password is not set
When password is not set, `{ 'PGPASSWORD' => password } unless password.nil?` evaluates to `nil`, setting `env_hash` to `nil`. `nil` is then passed as the first argument of `Open3.capture3` which result in an exception: ``` /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:213:in `spawn': no implicit conversion of nil into String (TypeError) from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:213:in `popen_run' from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:101:in `popen3' from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:281:in `capture3' from /opt/puppetlabs/mcollective/tasks-spool/899e9e0635bb53f1a09b4716548ff69f/files/sql.rb:13:in `get' from /opt/puppetlabs/mcollective/tasks-spool/899e9e0635bb53f1a09b4716548ff69f/files/sql.rb:27:in `<main>' ``` Make sure `env_hash` is always a hash to fix this issue.
Configuration menu - View commit details
-
Copy full SHA for b852434 - Browse repository at this point
Copy the full SHA b852434View commit details
Commits on Feb 1, 2021
-
Merge pull request #1225 from ekohl/use-major-version
Clean up globals logic to support CentOS 8 stream
Configuration menu - View commit details
-
Copy full SHA for 15c8728 - Browse repository at this point
Copy the full SHA 15c8728View commit details -
Merge pull request #1226 from smortex/fix-task
Fix postgresql::sql task when password is not set
Configuration menu - View commit details
-
Copy full SHA for 7d965b9 - Browse repository at this point
Copy the full SHA 7d965b9View commit details -
Merge pull request #1229 from puppetlabs/pdksync_gha-updates
pdksync - Update gha templates
Configuration menu - View commit details
-
Copy full SHA for 07d9965 - Browse repository at this point
Copy the full SHA 07d9965View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b44ad0 - Browse repository at this point
Copy the full SHA 1b44ad0View commit details -
Merge pull request #1231 from sheenaajay/disablecentos8
(IAC-1136) Back out CentOS 8 tests on TravisCI
sanfrancrisko authoredFeb 1, 2021 Configuration menu - View commit details
-
Copy full SHA for fe93ba9 - Browse repository at this point
Copy the full SHA fe93ba9View commit details
Commits on Feb 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4a06537 - Browse repository at this point
Copy the full SHA 4a06537View commit details
Commits on Feb 5, 2021
-
Merge pull request #1230 from sheenaajay/bug/1201/systemd
(bug) reload the service after the deletion of old unit file
Configuration menu - View commit details
-
Copy full SHA for 3c6e00e - Browse repository at this point
Copy the full SHA 3c6e00eView commit details -
Also perform systemd daemon-reload on Puppet 6.1+
The way daemon-reload is implemented in Puppet 6.1 is by calling systemctl show --property=NeedDaemonReload -- $SERVICE If that returns yes then it performs systemctl daemon-reload. However, this doesn't work reliable because of the particular case. # systemctl show --property=NeedDaemonReload -- postgresql Failed to get properties: Access denied This is probably because the original unit file is removed.
Configuration menu - View commit details
-
Copy full SHA for 3d47832 - Browse repository at this point
Copy the full SHA 3d47832View commit details -
Move the Template uses comment to the actual template
This moves it so it's closer to the actual call to template()
Configuration menu - View commit details
-
Copy full SHA for 18e7cf6 - Browse repository at this point
Copy the full SHA 18e7cf6View commit details -
Improve systemctl daemon-reload comment wording
Co-authored-by: Evgeni Golov <evgeni@golov.de>
Configuration menu - View commit details
-
Copy full SHA for 75cdb52 - Browse repository at this point
Copy the full SHA 75cdb52View commit details -
Merge pull request #1233 from ekohl/fix-systemd-reload
Also perform systemd daemon-reload on Puppet 6.1+
Configuration menu - View commit details
-
Copy full SHA for 8498326 - Browse repository at this point
Copy the full SHA 8498326View commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 88b6342 - Browse repository at this point
Copy the full SHA 88b6342View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc60361 - Browse repository at this point
Copy the full SHA bc60361View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d1c174e...bc60361