(PUPSUP-86) Update S0015 and AS001 #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reduces the threshold to flag S0015 and AS001 as false from 90 days to 30 days. This change was made since in PE 2023.4 certificate auto renewal is enabled and new certs having a validity of 90 days. Therefore, this avoids the indicators perpetually being in a false state. Also this commit fixes a typo changing 'too' to 'to' for gramatical clarity in agent_status_check.rb. No tests needed to be changed for these indicators.
jonathannewman
approved these changes
Feb 12, 2025
|
@jonathannewman thanks for the review. will this make it into the next PE releases? I see the change didn't land in release 4.5.2 |
|
and then needs to be added to vanagon for PE inclusion |
|
It is in 4.6.0 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces the threshold to flag S0015 and AS001 as false from 90 days to 30 days. This change was made since in PE 2023.4 certificate
auto renewal is enabled and new certs having a validity of 90 days.
Therefore, this avoids the indicators perpetually being in a false state. Also this commit fixes a typo changing 'too' to 'to' for gramatical clarity in agent_status_check.rb. No tests needed to be changed for these indicators.
Please check off the steps below as you complete each step
(SUP-XXXX) Add Super Duper State CheckReady for Reviewif there is one