Skip to content

node_group type: output wrong environment name #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppet/type/node_group.rb
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def insync?(is)
desc 'Environment for this group'
defaultto :production
validate do |value|
raise('Invalid environment name') unless value =~ (%r{\A[a-zA-Z0-9_]+\Z}) || (value == 'agent-specified')
raise("Invalid environment name: #{value}") unless value =~ (%r{\A[a-zA-Z0-9_]+\Z}) || (value == 'agent-specified')
end
end
newproperty(:classes) do
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/puppet/type/node_group_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
name: 'stubname',
environment: 'not-a-valid-name',
)
}.to raise_error(%r{Invalid environment name})
}.to raise_error(%r{Invalid environment name: not-a-valid-name})
end

it 'allows name with symbols, numbers, and whitespace' do
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.