Skip to content

(CONT-786) Add Support for Puppet 8 / Drop Support for Puppet 6 #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 5, 2023

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan requested a review from a team as a code owner May 23, 2023 09:36
@david22swan david22swan force-pushed the CONT-786/main/puppet_8 branch 3 times, most recently from c0cffcc to 74882a5 Compare June 2, 2023 11:21
New Versions:
rubocop = 1.48.1
rubocop-performance = 1.16.0
rubocop-rspec = 2.19.0
- Layout/BlockAlignment
- Layout/CaseIndentation
- Layout/ClosingHeredocIndentation
- Layout/EmptyLineAfterMagicComment
- Layout/EmptyLines
- Layout/EmptyLinesAroundClassBody
- Layout/EmptyLinesAroundExceptionHandlingKeywords
- Layout/EmptyLinesAroundMethodBody
- Layout/EndAlignment
- Layout/ExtraSpacing
- Layout/FirstArgumentIndentation
- Layout/FirstArrayElementIndentation
- Layout/HashAlignment
- Layout/HeredocIndentation
- Layout/IndentationConsistency
- Layout/IndentationWidth
- Layout/LeadingCommentSpace
- Layout/SpaceAfterComma
- Layout/SpaceAroundBlockParameters
- Layout/SpaceAroundOperators
- Layout/SpaceInsideArrayLiteralBrackets
- Layout/SpaceInsideBlockBraces
- Layout/SpaceInsideHashLiteralBraces
- Layout/TrailingEmptyLines
- Layout/TrailingWhitespace
- Lint/RedundantCopDisableDirective
- Lint/SymbolConversion
- Performance/RegexpMatch
- Performance/StringReplacement
- RSpec/EmptyHook
- RSpec/EmptyLineAfterExample
- RSpec/EmptyLineAfterExampleGroup
- RSpec/EmptyLineAfterHook
- RSpec/ExcessiveDocstringSpacing
- RSpec/ImplicitSubject
- Style/ClassMethods
- Style/ConditionalAssignment
- Style/EmptyLiteral
- Style/FileRead
- Style/FileWrite
- Style/BlockDelimiters
- Style/FetchEnvVar
- Style/NegatedIf
- Style/RedundantBegin
- Style/RedundantFileExtensionInRequire
- Style/GuardClause
- Style/HashSyntax
- Style/Next
- Style/RedundantRegexpEscape
- Style/RedundantStringEscape
- Style/IfUnlessModifier
- Style/RedundantReturn
- Style/RegexpLiteral
- Style/SelfAssignment
- Style/SoleNestedConditional
- Style/StringLiterals
- Style/StringLiteralsInInterpolation
- Style/TrailingCommaInHashLiteral
- Lint/NonAtomicFileOperation
- Performance/StringInclude
- Performance/UnfreezeString
- Style/CollectionCompact
- Style/CaseLikeIf
- Style/FrozenStringLiteralComment
- Style/GlobalStdStream
- Style/SlicingWithRange
- Style/SpecialGlobalVars
- Style/StringConcatenation
- Style/SymbolProc
@david22swan david22swan force-pushed the CONT-786/main/puppet_8 branch from 74882a5 to c3f7812 Compare June 2, 2023 11:22
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GSPatton GSPatton merged commit ab8b9b2 into puppetlabs:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants