Fix "password" as Property

[cocker-cc]

Having password defined with newparam, any Content of Type Sensitive will lead to

Unable to mark 'password' as sensitive: password is a parameter and not a property, and cannot be automatically redacted.

In Fact password (as well as others) should be a Property.
(compare https://puppet.com/docs/puppet/7/custom_types.html#tandp_properties_and_parameters)

[puppet-community-rangefinder]

java_ks is a type

Breaking changes to this file MAY impact these 18 modules (near match):

• ffquintella-dockerapp_wso2is
• treydock-keycloak
• shinesolutions-aem_curator
• elasticsearch-elasticsearch
• dmcnicks-mcoconfig
• sdodson-openshift_origin
• jmkeyes-gocd
• razorsedge-cloudera
• puppet-rundeck
• jmkeyes-unifi
• ploperations-activemq
• tedivm-hieratic
• CERNOps-activemq
• openshift-openshift_origin
• mvasilenko-gocd
• alkivi-activemq
• soli-wrappers
• ape-elasticsearch

This module is declared in 6 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[daianamezdrea]

Hi @cocker-cc, this looks good ! Thank you for opening the PR, cheers !