Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-8125) Fix unnecessary change when using intermediate certificates #250

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

johngmyers
Copy link
Contributor

No description provided.

@absltkaos
Copy link
Contributor

I just raised a small PR #252 that does a subset of this one. If this gets merged, mine can just be closed out.

I would love to get this working... Does anyone have an ETA on when this will be merged etc...?

@johngmyers
Copy link
Contributor Author

My experience shows this project takes one to two months to merge a PR. So ETA for merge would be late November/December if not allowing for holidays. Then it will be another few months for them to cut a release.

@david22swan
Copy link
Member

@johngmyers Your changes when tested against the adhoc pipeline present fail 48 times against windows 2012r2.

@johngmyers
Copy link
Contributor Author

@david22swan My changes passed the Travis and Appveyor tests visible here. Where is the failure report and how can I run those tests?

@johngmyers
Copy link
Contributor Author

Rebased and resolved conflicts.

@david22swan
Copy link
Member

screen shot 2018-11-01 at 11 02 07 am

@david22swan
Copy link
Member

Ok test's now passing green. Not sure where that failure came from but it repeated 3 times.
Happy to merge.

@david22swan david22swan merged commit 5cbf167 into puppetlabs:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants